feat: allow scalars to appear as the LHS arg in arithmetic operations on temporal values#6196
Merged
alamb merged 4 commits intoapache:mainfrom May 4, 2023
Merged
feat: allow scalars to appear as the LHS arg in arithmetic operations on temporal values#6196alamb merged 4 commits intoapache:mainfrom
alamb merged 4 commits intoapache:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6155
Rationale for this change
Currently, scalars cannot appear as the LHS arg in arithmetic operations on temporal values. This updates the relevant logic to accept scalars as the first argument.
What changes are included in this PR?
Updates the temporal arithmetic operations to accept scalars as the LHS arg.
Are these changes tested?
A test has been added for this new case.
Are there any user-facing changes?
No